Skip to content
/ wix Public

Implement UseArtifactsOutput to mirror the .NET SDK#598

Closed
brantburnett wants to merge 1 commit intowixtoolset:mainfrom
brantburnett:artifacts-path
Closed

Implement UseArtifactsOutput to mirror the .NET SDK#598
brantburnett wants to merge 1 commit intowixtoolset:mainfrom
brantburnett:artifacts-path

Conversation

@brantburnett
Copy link

@github-actions
Copy link

github-actions bot commented Jan 28, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@brantburnett
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

wixbot added a commit to wixtoolset/.github that referenced this pull request Jan 28, 2025
@brantburnett
Copy link
Author

@robmen I do have a couple of particular questions about this PR when you have a moment.

  1. Is the testing sufficient? What additional coverage would you like, more OutputTypes, more variations, or something included in WixE2E?
  2. I couldn't find documentation on current error codes, so I picked WIX9000 and WIX9001 for these new MSBuild-related errors as a placeholder.

@robmen robmen force-pushed the main branch 4 times, most recently from b5de212 to f181445 Compare February 12, 2025 23:09
@robmen
Copy link
Member

robmen commented Jun 18, 2025

Thanks but this copies in way too much code from the .NET project system. We'll need to find another way to share with them vs. copying in that much of their code.

@robmen robmen closed this Jun 18, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support .Net 8 preview 3 unified artifacts

2 participants